Bug 144443

Summary:

[CSS Box Alignment] Upgrade align-content parsing to CSS3 Box Alignment spec

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, darin, hyatt, jfernandez, rego, rniwa, svillar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60731, 91512, 133224

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch	none
Patch	none

Description Javier Fernandez 2015-04-30 03:37:15 PDT

Upgrade the align-content property to the last CSS3 Box Alignment specification. It uses the recently added enumeration for Positional and Distribution alignment, which requires changes in the FlexibleBox implementation.

Comment 1 Javier Fernandez 2015-05-04 13:07:43 PDT

Created attachment 252327 [details]
Patch

Comment 2 Build Bot 2015-05-04 14:11:53 PDT

Comment on attachment 252327 [details]
Patch

Attachment 252327 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5786138727940096

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
css3/parse-align-content.html
css3/parse-justify-content.html
fast/css/getComputedStyle/computed-style-without-renderer.html

Comment 3 Build Bot 2015-05-04 14:11:56 PDT

Created attachment 252331 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 4 Build Bot 2015-05-04 14:19:09 PDT

Comment on attachment 252327 [details]
Patch

Attachment 252327 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4962670016987136

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
css3/parse-align-content.html
css3/parse-justify-content.html
fast/css/getComputedStyle/computed-style-without-renderer.html

Comment 5 Build Bot 2015-05-04 14:19:11 PDT

Created attachment 252333 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 6 Javier Fernandez 2015-05-04 15:35:05 PDT

Created attachment 252340 [details]
Patch

Comment 7 Javier Fernandez 2015-05-04 16:10:00 PDT

Created attachment 252347 [details]
Patch

Comment 8 WebKit Commit Bot 2015-05-05 08:16:59 PDT

Comment on attachment 252347 [details]
Patch

Clearing flags on attachment: 252347

Committed r183805: <http://trac.webkit.org/changeset/183805>

Comment 9 WebKit Commit Bot 2015-05-05 08:17:05 PDT

All reviewed patches have been landed.  Closing bug.