Summary: | http/tests/cache/main-resource-304-reload.html failing on Windows | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> |
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | koivisto |
Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=144386 |
Description
Jon Honeycutt
2015-04-29 15:58:13 PDT
I'm pretty sure that isset would do the trick:
if (isset($_SERVER["HTTP_IF_MODIFIED_SINCE"])) {
> header("HTTP/1.0 304 Not Modified");
Why 1.0? Really weird to mix that with Cache-Control and ETags.
I just copied and lightly modified the script from LayoutTests/http/tests/cache/resources/iframe304.php. That is indeed silly. Switched both scripts to say HTTP/1.1 in https://trac.webkit.org/r183623. No idea if that fixes anything. This test was already marked failing on Windows in http://trac.webkit.org/changeset/183573 To fix the test, please see the first part of my comment, and use the isset() function. |