Bug 144316

Summary: [Win] Enable ES6 template literals
Product: WebKit Reporter: peavo
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ossy, rniwa, ysuzuki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ossy: review+

peavo
Reported 2015-04-28 00:08:21 PDT
This fixes some JSC stress tests failures on Windows.
Attachments
Patch (12.41 KB, patch)
2015-04-28 00:10 PDT, peavo 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-04-28 00:10:14 PDT
Created attachment 251829 [details] Patch
Yusuke Suzuki
Comment 2 2015-04-28 01:00:13 PDT
Oops, it's my fault. When I add a compile time flag, I missed to add it for windows ports.
peavo
Comment 3 2015-04-28 01:40:43 PDT
(In reply to comment #2) > Oops, it's my fault. > When I add a compile time flag, I missed to add it for windows ports. No worries :)
Csaba Osztrogonác
Comment 4 2015-04-28 02:34:46 PDT
Comment on attachment 251829 [details] Patch It was enabled everywhere, except Windows - accidentally. ( https://trac.webkit.org/changeset/183373 ) rs=me to enable on Windows too.
Yusuke Suzuki
Comment 5 2015-04-28 02:37:40 PDT
(In reply to comment #4) > Comment on attachment 251829 [details] > Patch > > It was enabled everywhere, except Windows - accidentally. ( > https://trac.webkit.org/changeset/183373 ) > > rs=me to enable on Windows too. Thank you for your review! BTW, it seems that ES6_CLASS_SYNTAX is also missing. Is it correct?
Csaba Osztrogonác
Comment 6 2015-04-28 03:11:58 PDT
(In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 251829 [details] > > Patch > > > > It was enabled everywhere, except Windows - accidentally. ( > > https://trac.webkit.org/changeset/183373 ) > > > > rs=me to enable on Windows too. > > Thank you for your review! > BTW, it seems that ES6_CLASS_SYNTAX is also missing. Is it correct? It can be added in a different patch, but it is already enabled from FeaturesDefines.h if it is missing here. https://trac.webkit.org/changeset/181618/trunk/Source/WTF/wtf/FeatureDefines.h
Yusuke Suzuki
Comment 7 2015-04-28 03:13:19 PDT
(In reply to comment #6) > It can be added in a different patch, but it is already > enabled from FeaturesDefines.h if it is missing here. > > https://trac.webkit.org/changeset/181618/trunk/Source/WTF/wtf/FeatureDefines. > h Make sense!
peavo
Comment 8 2015-04-28 03:49:26 PDT
Committed r183465: <http://trac.webkit.org/changeset/183465>
Note You need to log in before you can comment on or make changes to this bug.