Bug 144305

Summary: Implement font-synthesis CSS property
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch kling: review+

Description Myles C. Maxfield 2015-04-27 19:16:54 PDT 
Implement font-synthesis CSS property
Comment 1 Myles C. Maxfield 2015-04-27 20:57:22 PDT 
Created attachment 251818 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-27 20:58:20 PDT 
<rdar://problem/20692791>
Comment 3 Myles C. Maxfield 2015-04-27 21:08:55 PDT 
Created attachment 251819 [details]
Patch
Comment 4 Jon Lee 2015-04-27 23:37:30 PDT 
Comment on attachment 251819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251819&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:698
> +    bool syntheticOblique = (fontDescription.fontSynthesis & FontSynthesisStyle) && (traits & kCTFontTraitItalic) && !(actualTraits & kCTFontTraitItalic) && !isAppleColorEmoji;

Missing ()
Comment 5 Myles C. Maxfield 2015-04-28 11:02:35 PDT 
Created attachment 251863 [details]
Patch
Comment 6 Andreas Kling 2015-04-28 11:25:15 PDT 
Comment on attachment 251863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251863&action=review

r=me, looks good.

> Source/WebCore/css/StyleBuilderConverter.h:1224
> +    for (CSSValue& i : downcast<CSSValueList>(value)) {

'i' is kind of a weird name for a CSSValue& :)
Comment 7 Myles C. Maxfield 2015-04-28 11:38:14 PDT 
Committed r183494: <http://trac.webkit.org/changeset/183494>