Bug 144290

Summary:

[Content Extensions] Use less memory for CombinedURLFilters

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebCore Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2015-04-27 16:06:04 PDT

The prefix tree uses too much memory. Let's make it use less memory by using Vectors instead of HashTables, assuming the Vectors stay small because we still need to search through them.

Attachments
Patch (6.95 KB, patch) 2015-04-27 16:07 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (10.24 KB, patch) 2015-04-27 16:25 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (10.36 KB, patch) 2015-04-27 16:41 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (40.16 KB, patch) 2015-04-28 11:40 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2015-04-27 16:07:05 PDT

Created attachment 251783 [details] Patch

Alex Christensen

Comment 2 2015-04-27 16:25:08 PDT

Created attachment 251784 [details] Patch

Alex Christensen

Comment 3 2015-04-27 16:41:51 PDT

Created attachment 251785 [details] Patch

Alex Christensen

Comment 4 2015-04-27 16:46:44 PDT

This actually increases the memory usage. Strange...

Alex Christensen

Comment 5 2015-04-28 11:40:34 PDT

Created attachment 251871 [details] Patch

Andreas Kling

Comment 6 2015-04-28 11:49:53 PDT

Comment on attachment 251871 [details] Patch This seems pretty sensible. r=me I'm pretty sure we could drop the default 16 down to 8 or 4 too, but that would require a bit of testing.

Alex Christensen

Comment 7 2015-04-28 12:22:16 PDT

By the way, this reduces the memory usage of combinedURLFilters in ContentExtensionCompiler.cpp by a factor of 3.

WebKit Commit Bot

Comment 8 2015-04-28 12:41:33 PDT

Comment on attachment 251871 [details] Patch Clearing flags on attachment: 251871 Committed r183499: <http://trac.webkit.org/changeset/183499>

WebKit Commit Bot

Comment 9 2015-04-28 12:41:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.