Summary: | new super should be a syntax error | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||
Component: | JavaScriptCore | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, eric.carlson, fpizlo, ggaren, joepeck, kling | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 140491 | ||||||
Attachments: |
|
Description
Erik Arvidsson
2015-04-27 15:17:49 PDT
*** Bug 144281 has been marked as a duplicate of this bug. *** Created attachment 252291 [details]
Fixes the bug
Comment on attachment 252291 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=252291&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + ES6 classe: new super is not allowed Typo: "classe" => "classes" > Source/JavaScriptCore/parser/Parser.cpp:2527 > + semanticFailIfTrue(baseIsSuper && newCount, "Cannot new super"); I think there is room for improvement with this error message. The statement "Cannot new super" feels incomplete. Maybe "Cannot use new with super"? "Cannot call super as a constructor"? Comment on attachment 252291 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=252291&action=review >> Source/JavaScriptCore/parser/Parser.cpp:2527 >> + semanticFailIfTrue(baseIsSuper && newCount, "Cannot new super"); > > I think there is room for improvement with this error message. The statement "Cannot new super" feels incomplete. Maybe "Cannot use new with super"? "Cannot call super as a constructor"? Let's go with "Cannot use new with super". Committed r183757: <http://trac.webkit.org/changeset/183757> Thanks for the review, Joe! |