| Summary: | Consolidate most "frame load" arguments into FrameLoadRequest | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aestes, buildbot, commit-queue, japhet, rniwa | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 144269 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Brady Eidson
2015-04-27 13:55:09 PDT
There's a lot of work later to continue to whittle away the various "loadRequest" methods in FrameLoader, including minimizing the number of them that take all of the superfluous FrameLoadRequest arguments. But I'll be presenting a "good start" that consolidates down at least one of the entry points into FrameLoader. (blocking work on https://bugs.webkit.org/show_bug.cgi?id=144269) Created attachment 251786 [details]
Patch for EWS
Attachment 251786 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/FrameLoadRequest.h:112: Extra space between LockHistory and m_lockHistory [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/FrameLoadRequest.h:113: Extra space between LockBackForwardList and m_lockBackForwardList [whitespace/declaration] [3]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 251786 [details] Patch for EWS Attachment 251786 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5218143597232128 New failing tests: fast/dom/null-document-location-assign-crash.html http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html fast/dom/null-document-location-href-put-crash.html fast/dom/null-document-location-put-crash.html fast/dom/null-document-location-replace-crash.html http/tests/security/postMessage/javascript-page-still-sends-origin.html fast/loader/javascript-url-encoding-2.html http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html fast/dom/null-document-window-open-crash.html http/tests/security/aboutBlank/window-open-self-about-blank.html http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html Created attachment 251796 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 251786 [details] Patch for EWS Attachment 251786 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4656464618586112 New failing tests: fast/dom/null-document-location-assign-crash.html http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html fast/dom/null-document-location-href-put-crash.html fast/dom/null-document-location-put-crash.html fast/dom/null-document-location-replace-crash.html http/tests/security/postMessage/javascript-page-still-sends-origin.html fast/dom/null-document-window-open-crash.html http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html Created attachment 251800 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 251852 [details]
Patch EWS
Created attachment 251858 [details]
Patch for EWS
Created attachment 251869 [details]
Patch v1
Comment on attachment 251869 [details]
Patch v1
Is there any word that can be used instead of "request"? It's unpleasant to see code that deals with both ResourceRequest and FrameLoadRequest.
(In reply to comment #11) > Comment on attachment 251869 [details] > Patch v1 > > Is there any word that can be used instead of "request"? It's unpleasant to > see code that deals with both ResourceRequest and FrameLoadRequest. I agree completely. If we come up with a good alternative name, I would be happy to go do the rename in a different "rename-only" patch. Comment on attachment 251869 [details] Patch v1 Clearing flags on attachment: 251869 Committed r183498: <http://trac.webkit.org/changeset/183498> All reviewed patches have been landed. Closing bug. |