Summary: | Fix viewport units in Media Queries | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yoav Weiss
2015-04-27 06:41:45 PDT
Created attachment 251737 [details]
Patch
Comment on attachment 251737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251737&action=review > Source/WebCore/css/CSSPrimitiveValue.h:202 > unsigned short type = primitiveType(); > - return (type >= CSS_EMS && type <= CSS_PC) || type == CSS_REMS || type == CSS_CHS || isViewportPercentageLength(); > + return isLength(type); Should be done as a 1-liner. > Source/WebCore/css/CSSPrimitiveValue.h:233 > unsigned short type = primitiveType(); > - return type >= CSS_DPPX && type <= CSS_DPCM; > + return isResolution(type); Should be done as a 1-liner. Created attachment 251749 [details]
Patch
Comment on attachment 251749 [details] Patch Clearing flags on attachment: 251749 Committed r183404: <http://trac.webkit.org/changeset/183404> All reviewed patches have been landed. Closing bug. |