Bug 144260

Summary:

Fix viewport units in Media Queries

Product:

WebKit

Reporter:

Yoav Weiss <yoav>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Yoav Weiss 2015-04-27 06:41:45 PDT

Fix viewport units in Media Queries

Comment 1 Yoav Weiss 2015-04-27 06:51:00 PDT

Created attachment 251737 [details]
Patch

Comment 2 Darin Adler 2015-04-27 09:00:18 PDT

Comment on attachment 251737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251737&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:202
>          unsigned short type = primitiveType();
> -        return (type >= CSS_EMS && type <= CSS_PC) || type == CSS_REMS || type == CSS_CHS || isViewportPercentageLength();
> +        return isLength(type);

Should be done as a 1-liner.

> Source/WebCore/css/CSSPrimitiveValue.h:233
>          unsigned short type = primitiveType();
> -        return type >= CSS_DPPX && type <= CSS_DPCM;
> +        return isResolution(type);

Should be done as a 1-liner.

Comment 3 Yoav Weiss 2015-04-27 09:58:15 PDT

Created attachment 251749 [details]
Patch

Comment 4 WebKit Commit Bot 2015-04-27 11:43:44 PDT

Comment on attachment 251749 [details]
Patch

Clearing flags on attachment: 251749

Committed r183404: <http://trac.webkit.org/changeset/183404>

Comment 5 WebKit Commit Bot 2015-04-27 11:43:48 PDT

All reviewed patches have been landed.  Closing bug.