Summary: | Redefining a method of the same name hits an assertion | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | joepeck, mark.lam, ossy, rniwa, saam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 140491 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-04-27 03:11:40 PDT
re https://trac.webkit.org/changeset/183391 - run-javascriptcore-tests doesn't use TestExpectations file at all. If you want to skip it on JSC bots too, you need to add "//@ skip" into the test js file. (In reply to comment #1) > re https://trac.webkit.org/changeset/183391 - run-javascriptcore-tests > doesn't > use TestExpectations file at all. If you want to skip it on JSC bots too, you > need to add "//@ skip" into the test js file. That's a good point. We should do that. Done that in http://trac.webkit.org/changeset/183392. *** Bug 144514 has been marked as a duplicate of this bug. *** This has been fixed. Created attachment 275967 [details]
[PATCH] Proposed Fix - Unskip
Reopen to unskip.
Comment on attachment 275967 [details]
[PATCH] Proposed Fix - Unskip
Try again to get commit-queue to notice this.
Comment on attachment 275967 [details]
[PATCH] Proposed Fix - Unskip
Ugh, I'll just land manually.
|