Bug 144201

Summary:

Avoid using TBD as an argument to NS_AVAILABLE

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Use a version number instead of TBD	darin: review+

mitz

Reported 2015-04-25 17:38:31 PDT

<rdar://problem/20697966> CFAvailability.h tells us // Do not use TBD as an argument to NS_AVAILABLE but some of our generated bindings headers do it anyway.

Attachments
Use a version number instead of TBD (4.89 KB, patch) 2015-04-25 18:35 PDT, mitz	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2015-04-25 18:35:33 PDT

Created attachment 251661 [details] Use a version number instead of TBD

WebKit Commit Bot

Comment 2 2015-04-25 18:37:41 PDT

Attachment 251661 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/objc/WebKitAvailability.h:35: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

mitz

Comment 3 2015-04-25 18:39:59 PDT

Committed <http://trac.webkit.org/r183343>.

Alexey Proskuryakov

Comment 4 2015-04-25 23:00:42 PDT

This broke bindings generation tests on all bots, e.g.: -WEBKIT_CLASS_AVAILABLE_MAC(TBD) +WEBKIT_CLASS_AVAILABLE_MAC(9876_5) Is this the new expected behavior?

mitz

Comment 5 2015-04-25 23:01:39 PDT

(In reply to comment #4) > This broke bindings generation tests on all bots, e.g.: > > -WEBKIT_CLASS_AVAILABLE_MAC(TBD) > +WEBKIT_CLASS_AVAILABLE_MAC(9876_5) > > Is this the new expected behavior? I’m sorry, yes, it is expected.

mitz

Comment 6 2015-04-25 23:08:10 PDT

Updated the expected test results in <http://trac.webkit.org/r183350>.

Note You need to log in before you can comment on or make changes to this bug.