Bug 144193

Summary:

Rename WTF_USE_3D_GRAPHICS to ENABLE_GRAPHICS_CONTEXT_3D

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebCore Misc.

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, mcatanzaro, mrobinson, ossy, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Michael Catanzaro 2015-04-25 10:59:53 PDT

Rename WTF_USE_3D_GRAPHICS to ENABLE_GRAPHICS_CONTEXT_3D

See:

https://bugs.webkit.org/show_bug.cgi?id=144105#c5
https://lists.webkit.org/pipermail/webkit-dev/2015-April/027404.html

Comment 1 Michael Catanzaro 2015-04-25 11:10:18 PDT

Created attachment 251640 [details]
Patch

Comment 2 Michael Catanzaro 2015-04-25 12:09:59 PDT

Created attachment 251642 [details]
Patch

Comment 3 Martin Robinson 2015-04-25 14:57:06 PDT

Comment on attachment 251642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251642&action=review

> Source/cmake/OptionsEfl.cmake:92
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GRAPHICS_CONTEXT_3D PUBLIC ON)

I think this should always be private. It will always be the result of other options. In the case of EFL and GTK+, it's equivalent to texture_mapper_enabled || webgl_enabled. perhaps it shouldn't even be an option, just a variable that is set when certain options are present.

Comment 4 Michael Catanzaro 2015-04-25 20:04:37 PDT

(In reply to comment #3)
> I think this should always be private.

Yes, but EFL doesn't use private options yet (since I didn't want to pick and choose for them which to be private and which public).

> It will always be the result of other
> options. In the case of EFL and GTK+, it's equivalent to
> texture_mapper_enabled || webgl_enabled. perhaps it shouldn't even be an
> option, just a variable that is set when certain options are present.

OK, I agree. But if it's not an option, I'm not sure it should be named with ENABLE.

Comment 5 Martin Robinson 2015-04-27 11:44:05 PDT

(In reply to comment #4)
> OK, I agree. But if it's not an option, I'm not sure it should be named with
> ENABLE.

I think ENABLE is okay even if it's not an option, but I'm open to being convinced otherwise. :)

Comment 6 Michael Catanzaro 2015-04-27 14:39:12 PDT

Created attachment 251777 [details]
Patch

Comment 7 WebKit Commit Bot 2015-04-27 15:32:01 PDT

Comment on attachment 251777 [details]
Patch

Clearing flags on attachment: 251777

Committed r183432: <http://trac.webkit.org/changeset/183432>

Comment 8 WebKit Commit Bot 2015-04-27 15:32:05 PDT

All reviewed patches have been landed.  Closing bug.