Bug 144175

Summary:

theverge.com burning 100% CPU on iPad (due to window.screenX/Y)

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Andreas Kling

Reported 2015-04-24 16:57:55 PDT

<rdar://problem/20694585> theverge.com is burning up my iPad CPU asking for the screen dimensions over and over. Since they are always going to be 0,0/0x0 on iOS, let's just add a short-circuit and get rid of the expensive synchronous IPC.

Attachments
Patch (1.68 KB, patch) 2015-04-24 17:00 PDT, Andreas Kling	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2015-04-24 17:00:21 PDT

Created attachment 251595 [details] Patch

Anders Carlsson

Comment 2 2015-04-24 17:01:31 PDT

Comment on attachment 251595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251595&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:135 > #if PLATFORM(COCOA) Shouldn't this be #elif PLATFORM(MAC) then?

Andreas Kling

Comment 3 2015-04-24 17:26:49 PDT

Committed r183299: <http://trac.webkit.org/changeset/183299>

Note You need to log in before you can comment on or make changes to this bug.