Bug 144175

Summary:

theverge.com burning 100% CPU on iPad (due to window.screenX/Y)

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Andreas Kling 2015-04-24 16:57:55 PDT

<rdar://problem/20694585>

theverge.com is burning up my iPad CPU asking for the screen dimensions over and over. Since they are always going to be 0,0/0x0 on iOS, let's just add a short-circuit and get rid of the expensive synchronous IPC.

Comment 1 Andreas Kling 2015-04-24 17:00:21 PDT

Created attachment 251595 [details]
Patch

Comment 2 Anders Carlsson 2015-04-24 17:01:31 PDT

Comment on attachment 251595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251595&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:135
>  #if PLATFORM(COCOA)

Shouldn't this be #elif PLATFORM(MAC) then?

Comment 3 Andreas Kling 2015-04-24 17:26:49 PDT

Committed r183299: <http://trac.webkit.org/changeset/183299>