Bug 144153

Summary: [WK2] Only issue a isPlayingAudioDidChange() notification if the audio playing state actually changed.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Jer Noble
Reported 2015-04-24 10:47:27 PDT
[WK2] Only issue a isPlayingAudioDidChange() notification if the audio playing state actually changed.
Attachments
Patch (1.80 KB, patch)
2015-04-24 10:48 PDT, Jer Noble 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-04-24 10:48:42 PDT
Created attachment 251558 [details] Patch
Jer Noble
Comment 2 2015-04-24 10:50:05 PDT
rdar://problem/20677715
Alexey Proskuryakov
Comment 3 2015-04-24 10:57:12 PDT
Comment on attachment 251558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251558&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:5674 > + if ((oldState & MediaProducer::IsPlayingAudio) != (m_mediaState & MediaProducer::IsPlayingAudio)) At the beginning of this function, we have an early return when state == m_mediaState. I think that this should be an early return too, for consistency.
Jer Noble
Comment 4 2015-04-24 12:17:11 PDT
Committed r183276: <http://trac.webkit.org/changeset/183276>
Note You need to log in before you can comment on or make changes to this bug.