Bug 144153

Summary:

[WK2] Only issue a isPlayingAudioDidChange() notification if the audio playing state actually changed.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Jer Noble 2015-04-24 10:47:27 PDT

[WK2] Only issue a isPlayingAudioDidChange() notification if the audio playing state actually changed.

Comment 1 Jer Noble 2015-04-24 10:48:42 PDT

Created attachment 251558 [details]
Patch

Comment 2 Jer Noble 2015-04-24 10:50:05 PDT

rdar://problem/20677715

Comment 3 Alexey Proskuryakov 2015-04-24 10:57:12 PDT

Comment on attachment 251558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251558&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5674
> +    if ((oldState & MediaProducer::IsPlayingAudio) != (m_mediaState & MediaProducer::IsPlayingAudio))

At the beginning of this function, we have an early return when state == m_mediaState. I think that this should be an early return too, for consistency.

Comment 4 Jer Noble 2015-04-24 12:17:11 PDT

Committed r183276: <http://trac.webkit.org/changeset/183276>