Bug 144151 – [iOS] Reimplement r182512 and r183153 in a cleaner way

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Reimplement r182512 and r183153 in a cleaner way

[Myles C. Maxfield]

Created attachment 251559 [details]
Patch

[Enrica Casucci]

Comment on attachment 251559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251559&action=review

> Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm:-272
> -#endif // !PLATFORM(IOS)

Where did all the logic for cascadeToLastResortAndDisableSwashesFontDescriptor go? Are you sure this code is equivalent on iOS?

[Myles C. Maxfield]

Comment on attachment 251559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251559&action=review

>> Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm:-272
>> -#endif // !PLATFORM(IOS)
> 
> Where did all the logic for cascadeToLastResortAndDisableSwashesFontDescriptor go? Are you sure this code is equivalent on iOS?

It's above, see line 265.

The logic between the two code paths is exactly the same; the only difference is which underlying creation API we call. On OS X, we call CTFontCreateCopyWithAttributes() if we can, and CTFontCreateWithGraphicsFont() otherwise. Before this patch, on iOS, we would just always call CTFontCreateWithGraphicsFont (which has the problematic quality of losing system-font-ness). So the logic is the same, we're just switching to a different (and superior) API call.

[Myles C. Maxfield]

Committed r183271: <http://trac.webkit.org/changeset/183271>