Bug 144117

Summary: Linker fails without -DDEVELOPER_MODE=ON
Product: WebKit Reporter: Doug Newgard <scimmia22>
Component: JavaScriptCoreAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Error Log
none
Patch none

Doug Newgard
Reported 2015-04-23 13:29:27 PDT
Created attachment 251479 [details] Error Log Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot of Undefined Reference errors. See attached log.
Attachments
Error Log (58.81 KB, text/x-log)
2015-04-23 13:29 PDT, Doug Newgard 		no flags
Details
Patch (2.62 KB, patch)
2015-05-11 21:39 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-05-11 21:29:10 PDT
(In reply to comment #0) > Created attachment 251479 [details] > Error Log > > Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot > of Undefined Reference errors. See attached log. It's because of visibility CXX FLAGS. I will upload the patch not to use visibility. We can use linker script instead of it.
Ryuan Choi
Comment 2 2015-05-11 21:39:15 PDT
Created attachment 252931 [details] Patch
Gyuyoung Kim
Comment 3 2015-05-12 00:11:04 PDT
Comment on attachment 252931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252931&action=review LGTM. > Source/cmake/OptionsEfl.cmake:60 > + set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter") Oh, nice catch !
WebKit Commit Bot
Comment 4 2015-05-12 01:00:41 PDT
Comment on attachment 252931 [details] Patch Clearing flags on attachment: 252931 Committed r184166: <http://trac.webkit.org/changeset/184166>
WebKit Commit Bot
Comment 5 2015-05-12 01:00:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.