| Summary: | Linker fails without -DDEVELOPER_MODE=ON | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Doug Newgard <scimmia22> | ||||||
| Component: | JavaScriptCore | Assignee: | Ryuan Choi <ryuan.choi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ryuan.choi | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
(In reply to comment #0) > Created attachment 251479 [details] > Error Log > > Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot > of Undefined Reference errors. See attached log. It's because of visibility CXX FLAGS. I will upload the patch not to use visibility. We can use linker script instead of it. Created attachment 252931 [details]
Patch
Comment on attachment 252931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252931&action=review LGTM. > Source/cmake/OptionsEfl.cmake:60 > + set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter") Oh, nice catch ! Comment on attachment 252931 [details] Patch Clearing flags on attachment: 252931 Committed r184166: <http://trac.webkit.org/changeset/184166> All reviewed patches have been landed. Closing bug. |
Created attachment 251479 [details] Error Log Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot of Undefined Reference errors. See attached log.