Summary: | Regression: WebNetscapePluginPackage overagressively sets CurApRefNum, causes BBEdit to malfunction | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jim Correia <jim.correia> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | jim.correia, mrowe | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Jim Correia
2007-06-26 07:35:34 PDT
Created attachment 15246 [details]
Proposed patch for bug.
Comment on attachment 15246 [details]
Proposed patch for bug.
Good change.
Tab in the ChangeLog will need ot be removed to check in. Also I'd like the comment to mention the name and brief description of the bug, not just the ID.
Also, the (void) cast, while a common way to indicate that a function value is ignored, is not something we generally do in WebKit/Core code. I'd prefer to leave it out unless we have a tool that complains about ignored return values. I think the emphasis on the fact that the function is being used for its side effect is a good thing, but I think the comment already makes that clear and the ugly syntax is only really worthwhile in code where it's consistently used.
Created attachment 15259 [details]
Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]).
Comment on attachment 15259 [details]
Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]).
Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]).
Comment on attachment 15259 [details]
Revised patch. Updated ChangeLog comment, removed tabs. Removed cast to (void) in (+[WebNetscapePluginPackage initialize]).
r=me
|