Summary: | [cmake] Fix generate-js-builtins related incremental build issue | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | JavaScriptCore | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, gyuyoung.kim, ljharb, msaboff, oliver, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=143980 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-04-23 03:37:42 PDT
Created attachment 251426 [details]
Patch
cc-ed Oliver and Michael as the original author and reviewer of the generate-js-builtins script - http://trac.webkit.org/changeset/163195 I added the new --input-directory option to be able get rid of *.js from cmake and let the python script to collect js files. But I didn't remove the actual behaviour of the script, maybe somebody wants to generate builtins for a couple of js not for all js in a directory. Do you think if this change is acceptable to avoid incremental build issues in the future? ping? Comment on attachment 251426 [details]
Patch
r=me
Comment on attachment 251426 [details] Patch Clearing flags on attachment: 251426 Committed r183738: <http://trac.webkit.org/changeset/183738> All reviewed patches have been landed. Closing bug. |