| Summary: | Web Inspector: Make debugger keyboard shortcuts global | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | adam.g.helm, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2015-04-22 12:50:42 PDT
Created attachment 251358 [details]
Patch
Comment on attachment 251358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251358&action=review > Source/WebInspectorUI/ChangeLog:6 > + We wont always have a DebuggerSidebarPanel to listen for the shortcuts. Typo: "wont" => "won't". Would DebuggerManager be a better place instead of WebInspector / Main.js? The manager will always exist, these are wrapping DebuggerAgent APIs, and DebuggerManager is also sending the "Pause" / "Resume" events. Comment on attachment 251358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251358&action=review >> Source/WebInspectorUI/ChangeLog:6 >> + We wont always have a DebuggerSidebarPanel to listen for the shortcuts. > > Typo: "wont" => "won't". > > Would DebuggerManager be a better place instead of WebInspector / Main.js? > > The manager will always exist, these are wrapping DebuggerAgent APIs, and DebuggerManager is also sending the "Pause" / "Resume" events. Managers should not have UI (keyboard shortcuts). I don't think they will be in Test.html for example. > Managers should not have UI (keyboard shortcuts). I don't think they will be
> in Test.html for example.
Excellent point.
Comment on attachment 251358 [details] Patch Cleared review? from attachment 251358 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |