Bug 144068

Summary:

Web Inspector: Make debugger keyboard shortcuts global

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adam.g.helm, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Timothy Hatcher

Reported 2015-04-22 12:50:42 PDT

Move them out of DebuggerSidebarPanel.

Attachments
Patch (17.68 KB, patch) 2015-04-22 12:54 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2015-04-22 12:54:16 PDT

Created attachment 251358 [details] Patch

Joseph Pecoraro

Comment 2 2015-04-22 13:15:01 PDT

Comment on attachment 251358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251358&action=review > Source/WebInspectorUI/ChangeLog:6 > + We wont always have a DebuggerSidebarPanel to listen for the shortcuts. Typo: "wont" => "won't". Would DebuggerManager be a better place instead of WebInspector / Main.js? The manager will always exist, these are wrapping DebuggerAgent APIs, and DebuggerManager is also sending the "Pause" / "Resume" events.

Timothy Hatcher

Comment 3 2015-04-22 13:38:02 PDT

Comment on attachment 251358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251358&action=review >> Source/WebInspectorUI/ChangeLog:6 >> + We wont always have a DebuggerSidebarPanel to listen for the shortcuts. > > Typo: "wont" => "won't". > > Would DebuggerManager be a better place instead of WebInspector / Main.js? > > The manager will always exist, these are wrapping DebuggerAgent APIs, and DebuggerManager is also sending the "Pause" / "Resume" events. Managers should not have UI (keyboard shortcuts). I don't think they will be in Test.html for example.

Joseph Pecoraro

Comment 4 2015-04-22 13:44:28 PDT

> Managers should not have UI (keyboard shortcuts). I don't think they will be > in Test.html for example. Excellent point.

Timothy Hatcher

Comment 5 2015-04-25 18:36:16 PDT

r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342

Csaba Osztrogonác

Comment 6 2015-09-14 10:53:52 PDT

Comment on attachment 251358 [details] Patch Cleared review? from attachment 251358 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.