Bug 144020

Summary: Safari WebKit crash when loading Google Spreadsheet
Product: WebKit Reporter: John <john_94501>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Major CC: benjamin, commit-queue, fpizlo, mark.lam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.10   
Attachments:
Description Flags
Crashlog for the problem
none
Crashlog from nightly build r183168
none
Crashlog
none
the patch. none

Description John 2015-04-21 16:08:17 PDT
Created attachment 251272 [details]
Crashlog for the problem

Crash when opening a relatively large Google Spreadsheet in Safari 8.0.5 (10600.5.17) on a Yosemite device. The spreadsheet repeatedly shows the 'problem occurred loading' message and re-loads, in a loop. Then come the crash reports from OS X (see attached).
Comment 1 Benjamin Poulain 2015-04-22 13:45:42 PDT
<rdar://problem/20656809>
Comment 2 Benjamin Poulain 2015-04-22 13:52:51 PDT
Odd, I cannot reproduce on Yosemite.

Do you have any extension enabled?
Comment 3 Benjamin Poulain 2015-04-22 17:34:19 PDT
(In reply to comment #2)
> Odd, I cannot reproduce on Yosemite.
> 
> Do you have any extension enabled?

John answered that on twitter: no extension on his side.
Comment 4 John 2015-04-23 09:14:27 PDT
Tried with WebKit r183168 (built on 23 April 2015) and the initial load threw an error from Google about the document being unavailable (even though I could see most of the content behind the popup error). The reload button fixed that, and the second load was OK.

Sorting on column J ascending immediately threw the "A problem occurred with this webpage so it was reloaded" banner at the top and reloaded the sheet. This time it is not getting stuck in the loop doing that over and over though.

I will attach the crashlog for this.
Comment 5 John 2015-04-23 09:15:17 PDT
Created attachment 251444 [details]
Crashlog from nightly build r183168
Comment 6 Benjamin Poulain 2015-04-23 12:50:26 PDT
The last one is a FTL crash with security impact. Let's add Phil in CC.
Comment 7 Benjamin Poulain 2015-04-23 12:53:24 PDT
Created attachment 251472 [details]
Crashlog

I can reproduce with ToT.
-Open the document shared with the Safari testing.
-On the column "J", select "Sort sheet Z to A"
->crash in FTL.
Comment 8 Mark Lam 2015-04-29 11:11:09 PDT
Created attachment 251970 [details]
the patch.
Comment 9 WebKit Commit Bot 2015-04-29 12:01:27 PDT
Comment on attachment 251970 [details]
the patch.

Clearing flags on attachment: 251970

Committed r183564: <http://trac.webkit.org/changeset/183564>
Comment 10 WebKit Commit Bot 2015-04-29 12:01:32 PDT
All reviewed patches have been landed.  Closing bug.