Bug 14402 – Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

If you inspect http://www.apple.com/safari/ you will notice that the main resource is labeled "www.apple.com", while it should be labeled "safari".

Patch forthcoming.

[Adam Roben (:aroben)]

Created attachment 15234 [details]
Patch with ChangeLog

[Oliver Hunt]

Comment on attachment 15234 [details]
Patch with ChangeLog

this scares me as it could have substantial effects throughout webkit, are you sure there isn't anything that depends on this behaviour?

[Adam Roben (:aroben)]

(In reply to comment #2)
> (From update of attachment 15234 [details] [edit])
> this scares me as it could have substantial effects throughout webkit, are you
> sure there isn't anything that depends on this behaviour?

Surprisingly, there are only three calls to KURL::lastPathComponent outside of InspectorController.cpp. They are:

1) ClipboardWin.cpp::filesystemPathFromUrlOrTitle
2) ClipboardWin.cpp::writeURL
3) PasteboardWin.cpp::Pasteboard::writeURL

I don't think any of these callers intended to get a "/" returned for http://www.apple.com/safari/, so I feel fairly safe making this change.

[Oliver Hunt]

Comment on attachment 15234 [details]
Patch with ChangeLog

indeed you are correct, r=me

[Adam Roben (:aroben)]

Landed as r23779