Bug 143976 – PDFs still don't snapshot properly in iOS Safari

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

PDFs still don't snapshot properly in iOS Safari

[Tim Horton]

Created attachment 251210 [details]
Patch

[Tim Horton]

<rdar://problem/18283459>

[Anders Carlsson]

Comment on attachment 251210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251210&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2648
> +            CGContextRef ctx = UIGraphicsGetCurrentContext();

Please use context instead of context.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2650
> +            CGContextTranslateCTM(ctx, destinationRect.origin.x, destinationRect.origin.y);
> +            CGContextScaleCTM(ctx, imageScale, imageScale);

Do you need to save and restore the state here?

[Tim Horton]

(In reply to comment #3)
> Comment on attachment 251210 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251210&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2648
> > +            CGContextRef ctx = UIGraphicsGetCurrentContext();
> 
> Please use context instead of context.

You can't abbreviate it even if you want to :D

> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2650
> > +            CGContextTranslateCTM(ctx, destinationRect.origin.x, destinationRect.origin.y);
> > +            CGContextScaleCTM(ctx, imageScale, imageScale);
> 
> Do you need to save and restore the state here?

I don't think so, because it's a new context that was just created and will be lost very soon. Seems like that would be a waste of time, right?

[Tim Horton]

http://trac.webkit.org/changeset/183068