Summary: | Make Vector(const Vector<T, otherCapacity, otherOverflowBehaviour>&) constructor explicit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, benjamin, commit-queue, kling, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=143925 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2015-04-20 15:39:53 PDT
Created attachment 251195 [details]
Patch
Attachment 251195 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:71: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:308: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 251199 [details]
Patch
Attachment 251199 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:71: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:308: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 251205 [details]
Patch
Attachment 251205 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:71: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:308: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 251205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251205&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:155 > + BlockList preOrder = m_graph.blocksInPreOrder(); How about auto? > Source/WebCore/rendering/RenderGrid.cpp:174 > + const auto& children = m_grid[row][column]; I think in a case like the the "const" does little good. If the object is already const, then auto& keeps it const. If it’s not already const, then all const does is make it non-modifiable for like one line of code below, at the expense of adding another word! Yuck. Committed r183065: <http://trac.webkit.org/changeset/183065> |