| Summary: | HashMap storing PropertyKey StringImpl* need to use IdentifierRepHash to handle Symbols | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, benjamin, commit-queue, darin, fpizlo, ggaren | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2015-04-20 01:07:23 PDT
Created attachment 251155 [details]
Patch
Could anyone take a look? It fixes JSC test failures in 32bit debug builds. https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29 Attachment 251155 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 251156 [details]
Patch
Created attachment 251157 [details]
Patch
Comment on attachment 251157 [details]
Patch
Ha! I just had to fix this bug for another patch!
Comment on attachment 251157 [details] Patch Marking cq+ because we need this fix to fix the crash seen in https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/908/steps/jscore-test/logs/stdio. Comment on attachment 251157 [details] Patch Clearing flags on attachment: 251157 Committed r183022: <http://trac.webkit.org/changeset/183022> All reviewed patches have been landed. Closing bug. |