Bug 143935

Summary: [CMake] Synchronize variables between WebKitFeatures.cmake and cmakedonfig.h.cmake
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Gyuyoung Kim 2015-04-19 07:29:32 PDT
Some variables misses in these files or unused variables aren't removed. Let's fix it.
Comment 1 Gyuyoung Kim 2015-04-19 07:31:39 PDT
Created attachment 251119 [details]
Patch
Comment 2 Darin Adler 2015-04-19 10:38:38 PDT
Comment on attachment 251119 [details]
Patch

Is there a way we can change this so it’s not a manual process?
Comment 3 Gyuyoung Kim 2015-04-19 17:42:33 PDT
(In reply to comment #2)
> Comment on attachment 251119 [details]
> Patch
> 
> Is there a way we can change this so it’s not a manual process?

I think we may add this policy to check-coding-style, let me check it soon. Thanks.
Comment 4 WebKit Commit Bot 2015-04-19 18:29:40 PDT
Comment on attachment 251119 [details]
Patch

Clearing flags on attachment: 251119

Committed r182996: <http://trac.webkit.org/changeset/182996>
Comment 5 WebKit Commit Bot 2015-04-19 18:29:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2015-04-22 06:57:23 PDT
> Is there a way we can change this so it’s not a manual process?

See bug #143997. (Note that I hadn't noticed this bug yet when I filed that, so the lists I give in the first comment are a bit outdated.)