| Summary: | Web Inspector: REGRESSION: dragged node in the DOM Tree isn't positioned correctly | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | WebKit2 | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, enrica, graouts, joepeck, jonowells, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
We use DOM drag-n-drop API and this could be a regression in WebKit. Looking into it. It was broken somewhere between r182781 and r182765: http://trac.webkit.org/log/trunk/?rev=182781&stop_rev=182765 http://trac.webkit.org/changeset/182765/trunk is likely causing the problem. Enrica, could you take a look since it was your change? Seems when PageClientImpl::setDragImage makes the decision to use the WKWebView as the drag view, it needs to covert the location from WKView to WKWebView coordinates. Created attachment 254313 [details] [PATCH] Proposed Fix I tested: 1. Web Inspector reproducible case above 2. HTML5 drag example (worked before and after just fine) http://html5demos.com/drag in MiniBrowser 3. Dragging an Image off webkit.org in MiniBrowser Comment on attachment 254313 [details] [PATCH] Proposed Fix Clearing flags on attachment: 254313 Committed r185229: <http://trac.webkit.org/changeset/185229> All reviewed patches have been landed. Closing bug. |
Created attachment 251080 [details] Animated GIF of the problem See attached animated GIF. Steps: 1. Open Resources -> DOM Tree on any page that 2. Expand the tree deep enough to make it scrollable 3. Start dragging node Expected: The "ghost" node should be positioned right next to the mouse cursor. Actual: The ghost node’s top position is off.