Bug 14391

Summary:

[html-parsing] make entity handling match IE7 / HTML5

Product:

WebKit

Reporter:

Simon Pieters <zcorpan>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, commit-queue, eric, gsnedders, throwaway0account, vincent-webkit, webkit.review.bot, zcorpan

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

URL:

http://simon.html5.org/test/html/parsing/entities/trailing-semicolon/real/

Attachments:

Description	Flags
001: Entities in content	none
002: Entities in attributes	none
003: Entities in attributes	none
005: EOF while parsing an entity	none
tests in a diff	none
Patch	none
Patch	none

Simon Pieters

Reported 2007-06-25 10:02:10 PDT

Semi-colonless entities in content aren't supported (001). &TRADE; is not supported (001..003). If EOF is hit while parsing an entity, it is dropped altogether (005). (004 passes.) Relevant spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/section-tokenisation.html#tokenising

Attachments
001: Entities in content (9.34 KB, text/html) 2007-06-25 10:04 PDT, Simon Pieters	no flags	Details
002: Entities in attributes (9.54 KB, text/html) 2007-06-25 10:04 PDT, Simon Pieters	no flags	Details
003: Entities in attributes (9.36 KB, text/html) 2007-06-25 10:04 PDT, Simon Pieters	no flags	Details
005: EOF while parsing an entity (103 bytes, text/html) 2007-06-25 10:05 PDT, Simon Pieters	no flags	Details
tests in a diff (31.77 KB, patch) 2010-09-20 01:04 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch (32.74 KB, patch) 2010-09-20 01:21 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch (33.99 KB, patch) 2010-09-20 18:48 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Simon Pieters

Comment 1 2007-06-25 10:04:00 PDT

Created attachment 15226 [details] 001: Entities in content

Simon Pieters

Comment 2 2007-06-25 10:04:17 PDT

Created attachment 15227 [details] 002: Entities in attributes

Simon Pieters

Comment 3 2007-06-25 10:04:41 PDT

Created attachment 15228 [details] 003: Entities in attributes

Simon Pieters

Comment 4 2007-06-25 10:05:15 PDT

Created attachment 15229 [details] 005: EOF while parsing an entity

Alexey Proskuryakov

Comment 5 2007-07-02 06:01:55 PDT

Confirmed.

Adam Barth

Comment 6 2010-08-20 10:45:22 PDT

This most likely fixed now, but should be turned into some tests.

Adam Barth

Comment 7 2010-09-20 01:04:09 PDT

Looks like we might have a problem with the AElig entity. It's the first one on the list, so it could be a problem with the entity search.

Adam Barth

Comment 8 2010-09-20 01:04:41 PDT

Created attachment 68057 [details] tests in a diff

Adam Barth

Comment 9 2010-09-20 01:21:44 PDT

Created attachment 68058 [details] Patch

Adam Barth

Comment 10 2010-09-20 18:48:48 PDT

Created attachment 68174 [details] Patch

WebKit Commit Bot

Comment 11 2010-09-21 12:37:28 PDT

Comment on attachment 68174 [details] Patch Clearing flags on attachment: 68174 Committed r67975: <http://trac.webkit.org/changeset/67975>

WebKit Commit Bot

Comment 12 2010-09-21 12:37:34 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 13 2010-09-21 13:52:57 PDT

http://trac.webkit.org/changeset/67975 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67973 http://trac.webkit.org/changeset/67974 http://trac.webkit.org/changeset/67975 http://trac.webkit.org/changeset/67976 http://trac.webkit.org/changeset/67977 http://trac.webkit.org/changeset/67978 http://trac.webkit.org/changeset/67979

Note You need to log in before you can comment on or make changes to this bug.