Bug 143909

Summary:

Web Inspector: All sans-serif font family rules should be set the same way.

Product:

WebKit

Reporter:

Jonathan Wells <jonowells>

Component:

Web Inspector

Assignee:

Jonathan Wells <jonowells>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] style update	none

Description Jonathan Wells 2015-04-17 17:04:07 PDT

Our font-family rules for the sans-serif font are set in one of three ways:

font-family: -webkit-system-font, sans-serif; /* the is preferred */
font-family: Helvetica, sans-serif;
font-family: sans-serif;

All should be:

font-family: -webkit-system-font, sans-serif;

Comment 1 Radar WebKit Bug Importer 2015-04-17 17:04:25 PDT

<rdar://problem/20596200>

Comment 2 Jonathan Wells 2015-04-17 20:03:27 PDT

Created attachment 251079 [details]
[PATCH] style update

Comment 3 WebKit Commit Bot 2015-04-17 21:05:44 PDT

Comment on attachment 251079 [details]
[PATCH] style update

Clearing flags on attachment: 251079

Committed r182982: <http://trac.webkit.org/changeset/182982>

Comment 4 WebKit Commit Bot 2015-04-17 21:05:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2015-04-20 18:40:46 PDT

This caused a lot of regressions in ObjectTrees. On Yosemite, all of the text looks like it moved down a pixel, and is therefore off-balance. Is there a way we can fix this easily? Will we need to add body.yosemite adjustments?