Bug 143897 – prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Matthew Hanson]

When a Git combined diff hunk only includes one deletion, prepare-ChangeLog reports that the previous function/method has been modified.

[Matthew Hanson]

Created attachment 251045 [details]
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

[Matthew Hanson]

rdar://problem/20043230

[Radar WebKit Bug Importer]

<rdar://problem/20593033>

[Matthew Hanson]

<rdar://problem/20043230>

[David Kilzer (:ddkilzer)]

Comment on attachment 251045 [details]
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

View in context: https://bugs.webkit.org/attachment.cgi?id=251045&action=review

r- for commented out code.

> Tools/Scripts/prepare-ChangeLog:291
> +                # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) {

This shouldn't be commented out.  We don't check in commented out code.

[Matthew Hanson]

Created attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

[David Kilzer (:ddkilzer)]

Comment on attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

r=me.  If this causes any regressions, we should create some Perl unit tests before re-landing.

[Matthew Hanson]

Committed https://trac.webkit.org/r183030.

[Daniel Bates]

*** Bug 137889 has been marked as a duplicate of this bug. ***