| Summary: | prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Hanson <matthew_hanson> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dburkart, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Matthew Hanson
2015-04-17 14:12:08 PDT
Created attachment 251045 [details]
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
Comment on attachment 251045 [details] prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. View in context: https://bugs.webkit.org/attachment.cgi?id=251045&action=review r- for commented out code. > Tools/Scripts/prepare-ChangeLog:291 > + # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) { This shouldn't be commented out. We don't check in commented out code. Created attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
Comment on attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
r=me. If this causes any regressions, we should create some Perl unit tests before re-landing.
Committed https://trac.webkit.org/r183030. *** Bug 137889 has been marked as a duplicate of this bug. *** |