Bug 14389

Summary:

[S60] Widget Menu API needs refinement

Product:

WebKit

Reporter:

Sornalatha Rathnasamy <sornalatha.rathnasamy>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Enhancement

Keywords:

PlatformOnly

Priority:

Version:

523.x (Safari 3)

Hardware:

S60 Emulator

OS:

S60 3rd edition

Attachments:

Description	Flags
menu api and preferences	none
3.2 patch for menu api and preferences enhancement	zalan: review-
3.2 patch for menu api enhancement	zalan: review+
migrate fixes for SYAI-73AS6K and SYAI-73ARXK to 3.1	zalan: review+
3.1 patch	none
3.1 patch	zalan: review-

Sornalatha Rathnasamy

Reported 2007-06-25 08:46:44 PDT

TSW Id : ID: SYAI-73AS6K - Preferences - Key/Value pair implementation must be optimized - Ensure that only unique menu items APPENDED. Throw exception when new MenuItem call contains same id/text - Setting the callback after appending the menu item fails - Menu object is singleton. So no need for new menu() - Change menu item append behaviour to LIFO - Fix onshow, onhide behaviour - int value for set preference for key doesnt work

Attachments
menu api and preferences (24.72 KB, patch) 2007-06-25 11:28 PDT, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.2 patch for menu api and preferences enhancement (24.72 KB, patch) 2007-06-25 12:10 PDT, Sornalatha Rathnasamy	zalan: review-	Details Formatted Diff Diff
3.2 patch for menu api enhancement (24.81 KB, patch) 2007-06-26 07:33 PDT, Sornalatha Rathnasamy	zalan: review+	Details Formatted Diff Diff
migrate fixes for SYAI-73AS6K and SYAI-73ARXK to 3.1 (31.98 KB, patch) 2007-07-03 13:37 PDT, Sornalatha Rathnasamy	zalan: review+	Details Formatted Diff Diff
3.1 patch (4.91 KB, patch) 2007-07-12 13:02 PDT, Sornalatha Rathnasamy	no flags	Details Formatted Diff Diff
3.1 patch (1.17 KB, patch) 2007-07-12 13:20 PDT, Sornalatha Rathnasamy	zalan: review-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Sornalatha Rathnasamy

Comment 1 2007-06-25 11:28:32 PDT

Created attachment 15231 [details] menu api and preferences

Sornalatha Rathnasamy

Comment 2 2007-06-25 12:10:55 PDT

Created attachment 15232 [details] 3.2 patch for menu api and preferences enhancement

alan

Comment 3 2007-06-25 13:07:22 PDT

Comment on attachment 15232 [details] 3.2 patch for menu api and preferences enhancement widgetExtension.cpp line#860 >if ( newItem && oldItem && newItem->Text().Compare(newItem->Text()) != 0 ) shouldn't it be something like if ( newItem && oldItem && newItem->Text().CompareF(oldItem->Text()) == 0 ) ? WidgetPreferences.cpp - remove tabs, please. - line# 225, 251: missing CleanupStakc: PushL - line# 436: use allocL() instead - linr# 444: iValue = null; is missing and use allocL() instead.

Sornalatha Rathnasamy

Comment 4 2007-06-26 07:33:14 PDT

Created attachment 15245 [details] 3.2 patch for menu api enhancement

alan

Comment 5 2007-06-27 08:01:14 PDT

Comment on attachment 15245 [details] 3.2 patch for menu api enhancement r=me

alan

Comment 6 2007-06-27 08:01:54 PDT

r23814 -> ccb

Sornalatha Rathnasamy

Comment 7 2007-07-03 13:37:23 PDT

Created attachment 15376 [details] migrate fixes for SYAI-73AS6K and SYAI-73ARXK to 3.1

alan

Comment 8 2007-07-10 13:10:18 PDT

Comment on attachment 15376 [details] migrate fixes for SYAI-73AS6K and SYAI-73ARXK to 3.1 r=me

alan

Comment 9 2007-07-10 13:10:53 PDT

r24160 -> 3.1m

Sornalatha Rathnasamy

Comment 10 2007-07-12 13:02:56 PDT

Created attachment 15491 [details] 3.1 patch

Sornalatha Rathnasamy

Comment 11 2007-07-12 13:20:38 PDT

Created attachment 15494 [details] 3.1 patch

alan

Comment 12 2007-07-12 13:41:37 PDT

Comment on attachment 15494 [details] 3.1 patch r=me. the change is not needed.

Bradley Morrison

Comment 13 2008-04-09 11:39:40 PDT

Bulk closing of all s60 platform bugs. Sorry for the noise!

Note You need to log in before you can comment on or make changes to this bug.