Bug 14389

Summary: [S60] Widget Menu API needs refinement
Product: WebKit Reporter: Sornalatha Rathnasamy <sornalatha.rathnasamy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Enhancement Keywords: PlatformOnly
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Attachments:
Description Flags
menu api and preferences
none
3.2 patch for menu api and preferences enhancement
zalan: review-
3.2 patch for menu api enhancement
zalan: review+
migrate fixes for SYAI-73AS6K and SYAI-73ARXK to 3.1
zalan: review+
3.1 patch
none
3.1 patch zalan: review-

Description Sornalatha Rathnasamy 2007-06-25 08:46:44 PDT
TSW Id : ID:  SYAI-73AS6K 

- Preferences - Key/Value pair implementation must be optimized
- Ensure that only unique menu items APPENDED. Throw exception when new MenuItem call contains same id/text
- Setting the callback after appending the menu item fails
- Menu object is singleton. So no need for new menu()
- Change menu item append behaviour to LIFO
- Fix onshow, onhide behaviour
- int value for set preference for key doesnt work
Comment 1 Sornalatha Rathnasamy 2007-06-25 11:28:32 PDT
Created attachment 15231 [details]
menu api and preferences
Comment 2 Sornalatha Rathnasamy 2007-06-25 12:10:55 PDT
Created attachment 15232 [details]
3.2 patch for menu api and preferences enhancement
Comment 3 zalan 2007-06-25 13:07:22 PDT
Comment on attachment 15232 [details]
3.2 patch for menu api and preferences enhancement

widgetExtension.cpp line#860
>if ( newItem && oldItem && newItem->Text().Compare(newItem->Text()) != 0 )
shouldn't it be something like if ( newItem && oldItem && newItem->Text().CompareF(oldItem->Text()) == 0 ) ?

WidgetPreferences.cpp 
- remove tabs, please.
- line# 225, 251: missing CleanupStakc: PushL
- line# 436: use allocL() instead
- linr# 444: iValue = null; is missing and use allocL() instead.
Comment 4 Sornalatha Rathnasamy 2007-06-26 07:33:14 PDT
Created attachment 15245 [details]
3.2 patch for menu api enhancement
Comment 5 zalan 2007-06-27 08:01:14 PDT
Comment on attachment 15245 [details]
3.2 patch for menu api enhancement

r=me
Comment 6 zalan 2007-06-27 08:01:54 PDT
r23814 -> ccb
Comment 7 Sornalatha Rathnasamy 2007-07-03 13:37:23 PDT
Created attachment 15376 [details]
migrate fixes for SYAI-73AS6K  and SYAI-73ARXK to 3.1
Comment 8 zalan 2007-07-10 13:10:18 PDT
Comment on attachment 15376 [details]
migrate fixes for SYAI-73AS6K  and SYAI-73ARXK to 3.1

r=me
Comment 9 zalan 2007-07-10 13:10:53 PDT
r24160 -> 3.1m
Comment 10 Sornalatha Rathnasamy 2007-07-12 13:02:56 PDT
Created attachment 15491 [details]
3.1 patch
Comment 11 Sornalatha Rathnasamy 2007-07-12 13:20:38 PDT
Created attachment 15494 [details]
3.1 patch
Comment 12 zalan 2007-07-12 13:41:37 PDT
Comment on attachment 15494 [details]
3.1 patch

r=me. the change is not needed.
Comment 13 Bradley Morrison 2008-04-09 11:39:40 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!