Bug 143885

Summary:

build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-04-17 11:06:20 PDT

Found a case where we still show obsolete results. When there are two build with the same revision(s), we compare by id, and that always results in the check believing that we've got an in order build.

We should only check revisions for this sort, not id or loaded attributes.

Comment 1 Alexey Proskuryakov 2015-04-17 11:08:40 PDT

Created attachment 251032 [details]
proposed fix

Comment 2 WebKit Commit Bot 2015-04-17 12:09:16 PDT

Comment on attachment 251032 [details]
proposed fix

Clearing flags on attachment: 251032

Committed r182960: <http://trac.webkit.org/changeset/182960>

Comment 3 WebKit Commit Bot 2015-04-17 12:09:20 PDT

All reviewed patches have been landed.  Closing bug.