Bug 143855

Summary: Expose JavaScriptMarkupEnabled preference for WebKit1
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Sam Weinig 2015-04-16 16:23:26 PDT 
Expose JavaScriptMarkupEnabled preference for WebKit1
Comment 1 Sam Weinig 2015-04-16 16:25:46 PDT 
Created attachment 250974 [details]
Patch
Comment 2 mitz 2015-04-16 16:31:48 PDT 
Comment on attachment 250974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250974&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:2498
> +- (BOOL)isJavaScriptMarkupEnabled

The getter should just be javaScriptMarkupEnabled (see other recent examples in this class).

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:442
> +@property (nonatomic, getter=isJavaScriptMarkupEnabled) BOOL javaScriptMarkupEnabled;

So you don’t need a custom getter= here.
Comment 3 Sam Weinig 2015-04-16 17:29:20 PDT 
Committed r182928: <http://trac.webkit.org/changeset/182928>