Bug 143850

Summary:

Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, barraclough, commit-queue, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2015-04-16 15:40:15 PDT

Add assertions to make sure ActiveDOMObject::suspend() / resume() / stop() overrides don't fire events as this is not allowed. This would cause arbitrary JS execution which would be very dangerous in these stages.

Attachments
Patch (5.17 KB, patch) 2015-04-16 15:43 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2015-04-16 15:43:03 PDT

Created attachment 250957 [details] Patch

Chris Dumez

Comment 2 2015-04-16 15:48:31 PDT

I verified locally these assertions are not hit by the current layout tests.

Alexey Proskuryakov

Comment 3 2015-04-16 15:53:02 PDT

Comment on attachment 250957 [details] Patch Seems reasonable.

WebKit Commit Bot

Comment 4 2015-04-16 16:42:43 PDT

Comment on attachment 250957 [details] Patch Clearing flags on attachment: 250957 Committed r182923: <http://trac.webkit.org/changeset/182923>

WebKit Commit Bot

Comment 5 2015-04-16 16:42:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.