Bug 143847

Summary:

iOS Simulator.app no longer responds to AppleScript events after name change

Product:

WebKit

Reporter:

Jake Nielsen <jake.nielsen.webkit>

Component:

Tools / Tests

Assignee:

Jake Nielsen <jake.nielsen.webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, glenn, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+, commit-queue: commit-queue-
Forgot to change a callsite.	simon.fraser: review+, commit-queue: commit-queue-
Addresses comment.	dbates: review+, dbates: commit-queue-
Addresses Further Comments	none

Jake Nielsen

Reported 2015-04-16 14:37:21 PDT

Refer to rdar://problem/20530344

Attachments
Patch (1.74 KB, patch) 2015-04-16 14:41 PDT, Jake Nielsen	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Forgot to change a callsite. (3.07 KB, patch) 2015-04-16 15:16 PDT, Jake Nielsen	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Addresses comment. (3.01 KB, patch) 2015-04-16 15:34 PDT, Jake Nielsen	dbates: review+ dbates: commit-queue-	Details Formatted Diff Diff
Addresses Further Comments (3.01 KB, patch) 2015-04-16 16:10 PDT, Jake Nielsen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jake Nielsen

Comment 1 2015-04-16 14:41:44 PDT

Created attachment 250950 [details] Patch

WebKit Commit Bot

Comment 2 2015-04-16 14:47:53 PDT

Comment on attachment 250950 [details] Patch Rejecting attachment 250950 [details] from commit-queue. jake.nielsen.webkit@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Jake Nielsen

Comment 3 2015-04-16 15:16:09 PDT

Created attachment 250952 [details] Forgot to change a callsite.

Simon Fraser (smfr)

Comment 4 2015-04-16 15:17:25 PDT

Comment on attachment 250952 [details] Forgot to change a callsite. View in context: https://bugs.webkit.org/attachment.cgi?id=250952&action=review > Tools/ChangeLog:3 > + iOS Simulator.app no longer responds to AppleScript events after name changed to Simulator.app. Maybe change this.

WebKit Commit Bot

Comment 5 2015-04-16 15:18:19 PDT

Comment on attachment 250952 [details] Forgot to change a callsite. Rejecting attachment 250952 [details] from commit-queue. jacob_nielsen@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Jake Nielsen

Comment 6 2015-04-16 15:34:00 PDT

Created attachment 250956 [details] Addresses comment.

Daniel Bates

Comment 7 2015-04-16 16:07:20 PDT

Comment on attachment 250956 [details] Addresses comment. View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review > Tools/ChangeLog:3 > + Changes method of quitting iphone simulator to be more correct. "iphone simulator" => iOS Simulator > Tools/ChangeLog:7 > + Fixes by addressing the app by ID rather than by name. This is OK as-is. The bug description should come after the Reviewed By line. An example ChangeLog entry can be seen at <http://www.webkit.org/coding/contributing.html#changelogs>.

Daniel Bates

Comment 8 2015-04-16 16:09:19 PDT

Comment on attachment 250956 [details] Addresses comment. View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review >> Tools/ChangeLog:3 >> + Changes method of quitting iphone simulator to be more correct. > > "iphone simulator" => iOS Simulator This line should be the bug title. This reads like it should be part of the description.

Jake Nielsen

Comment 9 2015-04-16 16:10:59 PDT

Created attachment 250967 [details] Addresses Further Comments

WebKit Commit Bot

Comment 10 2015-04-16 18:29:49 PDT

Comment on attachment 250967 [details] Addresses Further Comments Clearing flags on attachment: 250967 Committed r182937: <http://trac.webkit.org/changeset/182937>

WebKit Commit Bot

Comment 11 2015-04-16 18:29:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.