| Summary: | iOS Simulator.app no longer responds to AppleScript events after name change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jake Nielsen <jake.nielsen.webkit> | ||||||||||
| Component: | Tools / Tests | Assignee: | Jake Nielsen <jake.nielsen.webkit> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, dbates, glenn, simon.fraser | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jake Nielsen
2015-04-16 14:37:21 PDT
Created attachment 250950 [details]
Patch
Comment on attachment 250950 [details] Patch Rejecting attachment 250950 [details] from commit-queue. jake.nielsen.webkit@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Created attachment 250952 [details]
Forgot to change a callsite.
Comment on attachment 250952 [details] Forgot to change a callsite. View in context: https://bugs.webkit.org/attachment.cgi?id=250952&action=review > Tools/ChangeLog:3 > + iOS Simulator.app no longer responds to AppleScript events after name changed to Simulator.app. Maybe change this. Comment on attachment 250952 [details] Forgot to change a callsite. Rejecting attachment 250952 [details] from commit-queue. jacob_nielsen@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Created attachment 250956 [details]
Addresses comment.
Comment on attachment 250956 [details] Addresses comment. View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review > Tools/ChangeLog:3 > + Changes method of quitting iphone simulator to be more correct. "iphone simulator" => iOS Simulator > Tools/ChangeLog:7 > + Fixes by addressing the app by ID rather than by name. This is OK as-is. The bug description should come after the Reviewed By line. An example ChangeLog entry can be seen at <http://www.webkit.org/coding/contributing.html#changelogs>. Comment on attachment 250956 [details] Addresses comment. View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review >> Tools/ChangeLog:3 >> + Changes method of quitting iphone simulator to be more correct. > > "iphone simulator" => iOS Simulator This line should be the bug title. This reads like it should be part of the description. Created attachment 250967 [details]
Addresses Further Comments
Comment on attachment 250967 [details] Addresses Further Comments Clearing flags on attachment: 250967 Committed r182937: <http://trac.webkit.org/changeset/182937> All reviewed patches have been landed. Closing bug. |