| Summary: | VarargsForwardingPhase should use bytecode liveness in addition to other uses to determine the last point that a candidate is used | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 143736 | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2015-04-16 14:03:45 PDT
Created attachment 250955 [details]
WRONG PATCH
Created attachment 251626 [details]
the patch
Attachment 251626 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGVarargsForwardingPhase.cpp:141: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGPhantomInsertionPhase.cpp:127: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 251626 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/183406 This appears to have regressed V8Spider/raytrace by 30% and Octane/raytrace by 9%. I think I broke VarargsForwarding with this change. (In reply to comment #6) > This appears to have regressed V8Spider/raytrace by 30% and Octane/raytrace > by 9%. I think I broke VarargsForwarding with this change. The fix is: https://bugs.webkit.org/show_bug.cgi?id=144340 |