Bug 143840

Summary:

Web Inspector: Special Logs to Console that do not have an expression should be styled differently, looks like code

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, hi, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
After Patch is applied	none
Patch	none

Joseph Pecoraro

Reported 2015-04-16 13:01:23 PDT

* SUMMARY Special Logs to Console that do not have an expression should be styled differently, looks like code. * STEPS TO REPRODUCe 1. Inspect <http://webkit.org> 2. Show DOM Tree 3. Right click <body> and "Log Element" => The "Selected Element" text in the console should be visually distinct, it looks identical to it having been code but it is not

Attachments
Patch (3.93 KB, patch) 2015-07-09 11:23 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.01 KB, patch) 2015-07-09 11:39 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
After Patch is applied (16.94 KB, image/png) 2015-07-09 11:40 PDT, Devin Rousso	no flags	Details
Patch (7.72 KB, patch) 2015-07-09 13:34 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-04-16 13:02:02 PDT

<rdar://problem/20575321>

Devin Rousso

Comment 2 2015-07-09 11:23:30 PDT

Created attachment 256492 [details] Patch

Devin Rousso

Comment 3 2015-07-09 11:24:59 PDT

Comment on attachment 256492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256492&action=review > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css:32 > +.console-user-command.special-user-log { I am not sure that this is the best styling here, but it's a start and doesn't look to bad at that.

Timothy Hatcher

Comment 4 2015-07-09 11:27:36 PDT

Comment on attachment 256492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256492&action=review >> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css:32 >> +.console-user-command.special-user-log { > > I am not sure that this is the best styling here, but it's a start and doesn't look to bad at that. A token (rounded box with colored background) is something we talked about doing here. Like email addresses in Mail.

Devin Rousso

Comment 5 2015-07-09 11:39:25 PDT

Created attachment 256495 [details] Patch

Devin Rousso

Comment 6 2015-07-09 11:40:04 PDT

Created attachment 256496 [details] After Patch is applied

Timothy Hatcher

Comment 7 2015-07-09 12:22:50 PDT

Comment on attachment 256495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256495&action=review > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:126 > - var commandMessageView = new WebInspector.ConsoleCommandView(text); > + var commandMessageView = new WebInspector.ConsoleCommandView(text, "special-user-log"); Two called of appendImmediateExecutionWithResult actually pass a JS property path as the text, so those cases should not get "special-user-log". You likely need to add a parameter to appendImmediateExecutionWithResult to toggle this class as needed. The callers do this: var text = isImpossible ? WebInspector.UIString("Selected Value") : propertyPath.displayPath(this.propertyPathType());

Devin Rousso

Comment 8 2015-07-09 13:34:30 PDT

Created attachment 256507 [details] Patch

WebKit Commit Bot

Comment 9 2015-07-09 14:55:17 PDT

Comment on attachment 256507 [details] Patch Clearing flags on attachment: 256507 Committed r186634: <http://trac.webkit.org/changeset/186634>

WebKit Commit Bot

Comment 10 2015-07-09 14:55:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.