Bug 143838

Summary: [ES6] Use specific functions for @@iterator functions
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, ljharb
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Yusuke Suzuki
Reported 2015-04-16 12:27:23 PDT
In ES6, some functions are used as the method with the different names. For example, Map.protoytpe[Symbol.iterator] === Map.prototype.entries Set.protoytpe[Symbol.iterator] === Set.prototype.values Array.protoytpe[Symbol.iterator] === Array.prototype.values %Arguments%[Symbol.iterator] === Array.prototype.values And we dropp Arguments' iterator implementation and its method for @@iterator since now they use Array Iterator and Array.protoype.values.
Attachments
Patch (56.73 KB, patch)
2015-04-16 12:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (57.12 KB, patch)
2015-04-16 13:15 PDT, Yusuke Suzuki 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-04-16 12:40:36 PDT
Created attachment 250940 [details] Patch
Yusuke Suzuki
Comment 2 2015-04-16 13:15:29 PDT
Created attachment 250945 [details] Patch
Geoffrey Garen
Comment 3 2015-04-16 13:23:16 PDT
Comment on attachment 250945 [details] Patch r=me
Yusuke Suzuki
Comment 4 2015-04-16 14:36:36 PDT
Committed r182911: <http://trac.webkit.org/changeset/182911>
Note You need to log in before you can comment on or make changes to this bug.