Bug 143819

Summary: [GTK] Run forwarding headers generator unconditionally
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, clopez, commit-queue, mrobinson, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=137394
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-04-16 03:04:42 PDT
bug137394 made it run depends on source code changes, but renaming headers caused incremental build issues. The runtime is quite short, approximately only 1 second, so let's run it unconditionally again. I already have a patch for it, I run the final test now and will upload if everything is good.
Attachments
Patch (5.76 KB, patch)
2015-04-16 03:17 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-04-16 03:17:59 PDT
Created attachment 250909 [details] Patch
Carlos Garcia Campos
Comment 2 2015-04-16 04:26:45 PDT
Comment on attachment 250909 [details] Patch Thanks!
Csaba Osztrogonác
Comment 3 2015-04-16 04:47:33 PDT
Comment on attachment 250909 [details] Patch Clearing flags on attachment: 250909 Committed r182882: <http://trac.webkit.org/changeset/182882>
Csaba Osztrogonác
Comment 4 2015-04-16 04:47:41 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2015-04-17 03:21:13 PDT
and a speculative fix landed in http://trac.webkit.org/changeset/182945
Csaba Osztrogonác
Comment 6 2015-04-17 04:19:50 PDT
I managed to reproduce the failure (with adding a long sleep into the WK2's fw header generator rule). We really need the dependency, because TestWebKitAPI contains zillion <WebKit/foo.h> Mac style framework include. I added it back in http://trac.webkit.org/changeset/182948 EFL didn't have this problem, because it generates fw-ing headers for WebKit2 too in TestWebKitAPI. It's so ugly, EFL should use the same solution, I'm going to change it.
Note You need to log in before you can comment on or make changes to this bug.