Bug 143811

Summary: Web Inspector: Remove unnecessary intermediate object from DOMTreeOutline
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-04-15 20:12:00 PDT
* SUMMARY Remove unnecessary intermediate object from DOMTreeOutline. this._eventSupport does nothing, since a TreeOutline is already a WebInspector.Object.
Attachments
[PATCH] Proposed Fix (2.76 KB, patch)
2015-04-15 20:13 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-04-15 20:13:50 PDT
Created attachment 250893 [details] [PATCH] Proposed Fix
Brian Burg
Comment 2 2015-04-16 07:58:30 PDT
Comment on attachment 250893 [details] [PATCH] Proposed Fix r=me After working with this code in the past week, I'm convinced the tree outlines have a lot more cleanup potential. It would be great to split them into views and data sources, for example.
WebKit Commit Bot
Comment 3 2015-04-16 08:44:33 PDT
Comment on attachment 250893 [details] [PATCH] Proposed Fix Clearing flags on attachment: 250893 Committed r182888: <http://trac.webkit.org/changeset/182888>
WebKit Commit Bot
Comment 4 2015-04-16 08:44:38 PDT
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 5 2015-04-16 10:33:08 PDT
(In reply to comment #2) > Comment on attachment 250893 [details] > [PATCH] Proposed Fix > > r=me > > After working with this code in the past week, I'm convinced the tree > outlines have a lot more cleanup potential. It would be great to split them > into views and data sources, for example. As our oldest file, dating back to 2007, I'd say so! I'd like to combine DataGrid and TreeOutline. They both do very similar things.
Note You need to log in before you can comment on or make changes to this bug.