Bug 143801

Summary:

Web Inspector: InspectorTest frontend console methods redirected to the frontend are wrong

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, cdumez, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-04-15 15:15:54 PDT

* SUMMARY
InspectorTest frontend console methods redirected to the frontend are wrong.

Test.js tries to redirect console.log/error/info as "LOG: args" etc, but they all end up as "INFO: " and have an extra comma in the arguments stringification.

Comment 1 Joseph Pecoraro 2015-04-15 15:17:30 PDT

Created attachment 250870 [details]
[PATCH] Proposed Fix

Comment 2 Brian Burg 2015-04-15 15:22:51 PDT

Comment on attachment 250870 [details]
[PATCH] Proposed Fix

r=me (Ouch, that is a dumb bug.)

I would have expected this to require test rebaselines..?

Comment 3 WebKit Commit Bot 2015-04-15 16:23:03 PDT

Comment on attachment 250870 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 250870

Committed r182870: <http://trac.webkit.org/changeset/182870>

Comment 4 WebKit Commit Bot 2015-04-15 16:23:07 PDT

All reviewed patches have been landed.  Closing bug.