Bug 143798

Summary:

Remove obsolete VMInspector debugging tool

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	none
patch 2: more deletion.	none
patch 3: removed an unneeded newline change.	msaboff: review+

Mark Lam

Reported 2015-04-15 14:54:32 PDT

I added the VMInspector tool 3 years ago to aid in VM hacking work. Some of it has bit rotted, and the VM also now has better ways achieve its functionality. Hence this code is now obsolete and should be removed.

Attachments
the patch. (29.82 KB, patch) 2015-04-15 15:02 PDT, Mark Lam	no flags	Details Formatted Diff Diff
patch 2: more deletion. (69.00 KB, patch) 2015-04-15 15:15 PDT, Mark Lam	no flags	Details Formatted Diff Diff
patch 3: removed an unneeded newline change. (68.62 KB, patch) 2015-04-15 15:19 PDT, Mark Lam	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2015-04-15 15:02:23 PDT

Created attachment 250866 [details] the patch.

Mark Lam

Comment 2 2015-04-15 15:15:17 PDT

Created attachment 250869 [details] patch 2: more deletion.

Mark Lam

Comment 3 2015-04-15 15:19:06 PDT

Created attachment 250871 [details] patch 3: removed an unneeded newline change.

Michael Saboff

Comment 4 2015-04-15 17:07:47 PDT

Comment on attachment 250871 [details] patch 3: removed an unneeded newline change. r=me

Mark Lam

Comment 5 2015-04-15 17:12:41 PDT

Thanks for the review. Landed in r182871: <http://trac.webkit.org/r182871>.

Note You need to log in before you can comment on or make changes to this bug.