Bug 143786

Summary: No matching __NSi_ definition for postprocessed value of WK_{MAC,IOS}_TBA
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Conditionally define __NSi_ for the current deployment target in WKFoundation.h andersca: review+

mitz
Reported 2015-04-15 10:32:38 PDT
Sometimes CFAvailability.h doesn’t have a definition of __NSi_ matching what WK_{MAC,IOS}_TBA expands to. <rdar://problem/20549298>
Attachments
Conditionally define __NSi_ for the current deployment target in WKFoundation.h (3.87 KB, patch)
2015-04-15 10:39 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-04-15 10:39:50 PDT
Created attachment 250822 [details] Conditionally define __NSi_ for the current deployment target in WKFoundation.h
Anders Carlsson
Comment 2 2015-04-15 10:43:11 PDT
Comment on attachment 250822 [details] Conditionally define __NSi_ for the current deployment target in WKFoundation.h View in context: https://bugs.webkit.org/attachment.cgi?id=250822&action=review > Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:45 > +// POSTPROCESSING_INSERTS_DEPLOYMENT_TARGET_AVAILABILITY_DEFINITION_HERE Maybe add a DO_NOT_REMOVE so nobody will remove it?
mitz
Comment 3 2015-04-15 10:52:06 PDT
Fixed in <http://webkit.org/r182846>.
Note You need to log in before you can comment on or make changes to this bug.