| Summary: | [W32] windowsVersion() and osVersionForUAString() are outdated | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | LRN <lrn1986> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, lrn1986 | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 133028 | ||||||||
| Attachments: |
|
||||||||
|
Description
LRN
2015-04-15 06:33:19 PDT
Created attachment 250818 [details]
Update windowsVersion() and osVersionForUAString()
Add support for newer Windows versions to windowsVersion(), handle all
defined cases in osVersionForUAString(), avoiding warnings like
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value
Attachment 250818 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/win/SystemInfo.cpp:74: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/win/SystemInfo.cpp:82: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/ChangeLog:16: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 250843 [details]
Update windowsVersion() and osVersionForUAString()
Add support for newer Windows versions to windowsVersion(), handle all
defined cases in osVersionForUAString(), avoiding warnings like
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value
Committed to 2.4 http://trac.webkit.org/changeset/184490 Comment on attachment 250818 [details] Update windowsVersion() and osVersionForUAString() Cleared Darin Adler's review+ from obsolete attachment 250818 [details] so that this bug does not appear in http://webkit.org/pending-commit. |