Bug 143769

Summary: [W32] Fails to build - missing references to OpenGL context functions
Product: WebKit Reporter: LRN <lrn1986>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, lrn1986
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133028    
Attachments:
Description Flags
Also use GL-related files when compiling with MinGW none

LRN
Reported 2015-04-15 06:31:49 PDT
CXXLD libwebkitgtk-3.0.la ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `GraphicsContext3DPrivate': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext14sharingContextEv' /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext22createOffscreenContextEPS0_' ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `platformContext': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:84: undefined reference to `__ZN7WebCore9GLContext10getCurrentEv' Becuase GLContext.cpp is not used, which happens because it's under TARGET_X11_OR_WAYLAND condition in the GNUmakefile.list.am.
Attachments
Also use GL-related files when compiling with MinGW (4.55 KB, patch)
2015-04-15 10:10 PDT, LRN 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
LRN
Comment 1 2015-04-15 10:10:44 PDT
Created attachment 250816 [details] Also use GL-related files when compiling with MinGW CXXLD libwebkitgtk-3.0.la ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `GraphicsContext3DPrivate': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext14sharingContextEv' /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext22createOffscreenContextEPS0_' ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `platformContext': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:84: undefined reference to `__ZN7WebCore9GLContext10getCurrentEv' Becuase GLContext.cpp is not used, which happens because it's under TARGET_X11_OR_WAYLAND condition in the GNUmakefile.list.am. Move TARGET_X11_OR_WAYLAND up a bit to free up GLContext.cpp (now only protected by USE_OPENGL).
Carlos Garcia Campos
Comment 2 2015-05-18 23:06:35 PDT
Comment on attachment 250816 [details] Also use GL-related files when compiling with MinGW Clearing flags, committed a slightly modified version of the patch. LRN confirmed it works for him
Carlos Garcia Campos
Comment 3 2015-05-18 23:07:27 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184544
Note You need to log in before you can comment on or make changes to this bug.