Bug 143762

Summary:

[ANGLE][W32] Buildsystem is hardcoded for UNIX

Product:

WebKit

Reporter:

LRN <lrn1986>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, lrn1986

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

133028

Attachments:

Description	Flags
Don't hardcode ossource_posix.cpp in the makefile	cgarcia: review+, cgarcia: commit-queue-

LRN

Reported 2015-04-15 06:24:07 PDT

Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp is compiled unconditionally.

Attachments
Don't hardcode ossource_posix.cpp in the makefile (2.77 KB, patch) 2015-04-15 09:57 PDT, LRN	cgarcia: review+ cgarcia: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

LRN

Comment 1 2015-04-15 09:57:36 PDT

Created attachment 250807 [details] Don't hardcode ossource_posix.cpp in the makefile Compile ossource_posix.cpp or ossource_win.cpp depending on the target. Otherwise you get an error: ../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:13:2: error: #error Trying to build a posix specific file in a non-posix build.

Carlos Garcia Campos

Comment 2 2015-05-18 23:19:35 PDT

Committed to 2.4 http://trac.webkit.org/changeset/184545

Note You need to log in before you can comment on or make changes to this bug.