Bug 143730

Summary:

Make creating send rights from shared memory more robust

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2015-04-14 15:07:42 PDT

Make creating send rights from shared memory more robust

Comment 1 Anders Carlsson 2015-04-14 15:12:24 PDT

Created attachment 250743 [details]
Patch

Comment 2 Darin Adler 2015-04-14 16:42:23 PDT

Comment on attachment 250743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250743&action=review

> Source/WebKit2/Platform/SharedMemory.h:104
> +    WebCore::MachSendRight createSendRight(Protection) const;

Platforms are getting this:

    error: 'MachSendRight' in namespace 'WebCore' does not name a type

I think that means you need to wrap the declaration here in #if OS(DARWIN) like the forward declaration above is.

Comment 3 Anders Carlsson 2015-04-15 10:33:25 PDT

Committed r182845: <http://trac.webkit.org/changeset/182845>