Bug 143713

Summary: Generalize "isPlayingAudio" to include other media characteristics
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Patch for the landing.
none
Patch for the bots.
none
Another patch for the bots. none

Eric Carlson
Reported 2015-04-14 08:46:53 PDT
Generalize "isPlayingAudio" to include other media characteristics
Attachments
Proposed patch (12.50 KB, patch)
2015-04-14 08:59 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for the landing. (30.37 KB, patch)
2015-04-14 12:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for the bots. (42.97 KB, patch)
2015-04-15 05:46 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Another patch for the bots. (46.00 KB, patch)
2015-04-15 08:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-04-14 08:59:45 PDT
Created attachment 250709 [details] Proposed patch
Jer Noble
Comment 2 2015-04-14 10:37:16 PDT
Comment on attachment 250709 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=250709&action=review r=me, with questions: > Source/WebCore/page/Page.cpp:-111 > -#include "MediaPlaybackTargetPickerClient.h" Is this really no longer needed? > Source/WebCore/page/Page.cpp:1216 > - chrome().client().isPlayingAudioDidChange(m_isPlayingAudio); > + chrome().client().isPlayingMediaDidChange(m_isPlayingAudio ? ChromeClient::IsPlayingAudio : ChromeClient::IsNotPlaying); > } Are we going to add support for IsPlayingVideo and IsPlayingToExternalDevice in a follow-up patch?
Eric Carlson
Comment 3 2015-04-14 12:50:01 PDT
Created attachment 250726 [details] Patch for the landing.
WebKit Commit Bot
Comment 4 2015-04-14 12:51:28 PDT
Attachment 250726 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 5 2015-04-15 05:46:35 PDT
Created attachment 250786 [details] Patch for the bots.
WebKit Commit Bot
Comment 6 2015-04-15 05:48:21 PDT
Attachment 250786 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 7 2015-04-15 08:50:51 PDT
Created attachment 250792 [details] Another patch for the bots.
WebKit Commit Bot
Comment 8 2015-04-15 08:52:32 PDT
Attachment 250792 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1938: Extra space before [ [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3102: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 9 2015-04-15 09:21:42 PDT
Committed r182842: https://trac.webkit.org/r182842
Note You need to log in before you can comment on or make changes to this bug.