Bug 143668

Summary: Network Cache: Add thread-safe accessors for storage paths
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Antti Koivisto
Reported 2015-04-13 08:11:11 PDT
Less need for clunky StringCaptures.
Attachments
patch (10.45 KB, patch)
2015-04-13 08:37 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-04-13 08:37:54 PDT
Created attachment 250639 [details] patch
Darin Adler
Comment 2 2015-04-13 09:55:09 PDT
Comment on attachment 250639 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=250639&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:83 > + const String baseDirectoryPath() const; > + const String directoryPath() const; I don’t understand the value of returning const String rather than String. These should just return String.
Anders Carlsson
Comment 3 2015-04-13 11:29:43 PDT
Comment on attachment 250639 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=250639&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:79 > + // This is safe from any thread. > + return StringView(m_baseDirectoryPath).toString(); I think this could just call m_baseDirectoryPath.isolatedCopy() (if m_baseDirectoryPath was kept a String)
Antti Koivisto
Comment 4 2015-04-15 04:21:04 PDT
https://trac.webkit.org/r182841
Note You need to log in before you can comment on or make changes to this bug.