Number.parseInt in nightly r182673 has wrong length

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Jordan Harband]

Number.parseInt takes 2 arguments, and as such, should have a length of 2. In r182673, it has a length of 1. https://people.mozilla.org/~jorendorff/es6-draft.html#sec-number.parseint

In addition, `Number.parseInt === parseInt` should return true, and does not. Note that `parseInt` has a proper length of 2.

[Jordan Harband]

Created attachment 250846 [details]
Patch

[Jordan Harband]

Created attachment 250850 [details]
Patch

[Benjamin Poulain]

Comment on attachment 250850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250850&action=review

> Source/JavaScriptCore/ChangeLog:8
> +

Usually that is where you describe the change. The link to the spec would go here too.

> LayoutTests/ChangeLog:4
> +        https://people.mozilla.org/~jorendorff/es6-draft.html#sec-number.parseint

No need to repeat that. The information in each changelog explain the change for that particular subdirectory.

> LayoutTests/js/script-tests/number-constructor.js:134
> +// https://people.mozilla.org/~jorendorff/es6-draft.html#sec-number.parseint
> +shouldBe('Number.parseInt.length', '2'); // ES6 spec requires length matching number of required args

No need for the comments. It is clearly a dumb bug.

[Jordan Harband]

Created attachment 250851 [details]
Patch

[Benjamin Poulain]

Comment on attachment 250851 [details]
Patch

I'll land myself.

[Benjamin Poulain]

Created attachment 250853 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 250853 [details]
Patch for landing

Clearing flags on attachment: 250853

Committed r182863: <http://trac.webkit.org/changeset/182863>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.