Summary: | Cannot click "Next" button on Google two-factor auth setup page | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> | ||||
Component: | Forms | Assignee: | Jon Honeycutt <jhoneycutt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | enrica | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | iOS 8.2 | ||||||
Attachments: |
|
Description
Jon Honeycutt
2015-04-10 18:25:27 PDT
Created attachment 250557 [details]
Patch
Comment on attachment 250557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250557&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2784 > + default: I think we should list all InputTypes here explicitly (instead of using 'default') so that new values will cause a build failure, and a will force a decision to be made by the patch author. Comment on attachment 250557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250557&action=review >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2784 >> + default: > > I think we should list all InputTypes here explicitly (instead of using 'default') so that new values will cause a build failure, and a will force a decision to be made by the patch author. I agree. Then we can also stick an ASSERT_NOT_REACHED() after the switch (along with a second return false). Please make that change. Committed r182749: <http://trac.webkit.org/changeset/182749> |