Bug 143621

Summary:

Hide volume controls when playing wirelessly

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	darin: review+

Description Roger Fong 2015-04-10 16:12:49 PDT

Hide volume controls when playing wirelessly

Comment 1 Roger Fong 2015-04-10 16:13:17 PDT

rdar://problem/20490673

Comment 2 Roger Fong 2015-04-10 16:48:12 PDT

Created attachment 250540 [details]
patch

Comment 3 Darin Adler 2015-04-10 19:49:32 PDT

Comment on attachment 250540 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250540&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1776
> +                if (!this.controls.panel.contains(this.controls.volumeBox))

Would it be more efficient to check the parent of volumeBox rather than calling contains?

Comment 4 Roger Fong 2015-04-10 23:25:34 PDT

True this. Committed with changes:
http://trac.webkit.org/changeset/182652