Bug 143621

Summary: Hide volume controls when playing wirelessly
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Roger Fong
Reported 2015-04-10 16:12:49 PDT
Hide volume controls when playing wirelessly
Attachments
patch (2.01 KB, patch)
2015-04-10 16:48 PDT, Roger Fong 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2015-04-10 16:13:17 PDT
rdar://problem/20490673
Roger Fong
Comment 2 2015-04-10 16:48:12 PDT
Created attachment 250540 [details] patch
Darin Adler
Comment 3 2015-04-10 19:49:32 PDT
Comment on attachment 250540 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=250540&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1776 > + if (!this.controls.panel.contains(this.controls.volumeBox)) Would it be more efficient to check the parent of volumeBox rather than calling contains?
Roger Fong
Comment 4 2015-04-10 23:25:34 PDT
True this. Committed with changes: http://trac.webkit.org/changeset/182652
Note You need to log in before you can comment on or make changes to this bug.